Don't escape tab characters when saving source members#3129
Closed
SamJessep wants to merge 1 commit intocodefori:masterfrom
Closed
Don't escape tab characters when saving source members#3129SamJessep wants to merge 1 commit intocodefori:masterfrom
SamJessep wants to merge 1 commit intocodefori:masterfrom
Conversation
Collaborator
|
@SamJessep Thank you for the PR - but please see my comment here on why this should not be implemented. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This change seems to fix the issue mentioned here #3060
Here is my example of a program where the tab character was added just before dsply then ran crtbndpgm

With the change I can save the source file with tabs and compile it fine & the existing tests still pass.
Maybe I'm missing the reason why tab escaping was needed?
How to test this PR
Checklist
console.logs I added