Skip to content

Don't escape tab characters when saving source members#3129

Closed
SamJessep wants to merge 1 commit intocodefori:masterfrom
SamJessep:fix/store_unescaped_tabs
Closed

Don't escape tab characters when saving source members#3129
SamJessep wants to merge 1 commit intocodefori:masterfrom
SamJessep:fix/store_unescaped_tabs

Conversation

@SamJessep
Copy link
Copy Markdown
Contributor

Changes

This change seems to fix the issue mentioned here #3060

Here is my example of a program where the tab character was added just before dsply then ran crtbndpgm
Screenshot 2026-03-29 170917

With the change I can save the source file with tabs and compile it fine & the existing tests still pass.

Maybe I'm missing the reason why tab escaping was needed?

How to test this PR

  1. Create a rpgle program with ccsid 37
  2. Add a tab character via vs code (change editor settings to use tabs over spaces)
  3. Save and compile
  4. Program compiles without errors

Checklist

  • have tested my change
  • have created one or more test cases
  • Remove any/all console.logs I added

@chrjorgensen
Copy link
Copy Markdown
Collaborator

@SamJessep Thank you for the PR - but please see my comment here on why this should not be implemented. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants