Skip to content

Dev #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardhanna merged 2 commits into from
Feb 24, 2026
Merged

Dev #3397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b909cc6
certs fix
bernardhanna Feb 24, 2026
7d9fe77
Merge pull request #3396 from codeeu/week_10_feb
bernardhanna Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/Http/Controllers/CertificateBackendController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,10 @@ public function manualCreateSend(Request $request): JsonResponse
$name = $excellence->name_for_certificate ?? trim($user->firstname . ' ' . $user->lastname);
$numberOfActivities = $type === 'SuperOrganiser' ? $user->activities($edition) : 0;

if (! $sendOnly && ! $excellence->certificate_url) {
// Manual "generate only" should always regenerate, even if a URL already exists.
// For combined flow, only generate when certificate is missing.
$shouldGenerate = ! $sendOnly && ($generateOnly || ! $excellence->certificate_url);
if ($shouldGenerate) {
try {
$cert = new \App\CertificateExcellence(
$edition,
Expand Down
Loading