Open
Conversation
bench 3554133
bench 3554133
87flowers
reviewed
Mar 25, 2026
|
|
||
| if !mv.is_en_passant() && !(self.checkers() | between(king, self.checkers().lsb())).contains(to) { | ||
| if self.checkers().is_multiple() | ||
| || !(mv.is_en_passant() || (self.checkers() | between(king, self.checkers().lsb())).contains(to)) |
Contributor
There was a problem hiding this comment.
I don't enjoy this specific change as this makes it harder to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly non-functional.
We only set the tt_move when it is NOT Null, so checking it again here is not necessary. Also, consolidate some conditions.
bench 3554133
STC
Elo | 1.87 +- 2.18 (95%)
SPRT | 8.0+0.08s Threads=1 Hash=16MB
LLR | 2.98 (-2.25, 2.89) [-2.75, 0.25]
Games | N: 23748 W: 5955 L: 5827 D: 11966
Penta | [49, 2615, 6434, 2711, 65]
https://recklesschess.space/test/12620/