Skip to content

React 19 / vite 8#507

Merged
joshreisner merged 5 commits intocode4recovery:mainfrom
pjaudiomv:pj/react-19
Apr 3, 2026
Merged

React 19 / vite 8#507
joshreisner merged 5 commits intocode4recovery:mainfrom
pjaudiomv:pj/react-19

Conversation

@pjaudiomv
Copy link
Copy Markdown
Collaborator

react-infinite-scroller is no longer maintained, we could fork it but easier to just remove dep

vite migrated from rollup to rolldown https://v7.vite.dev/guide/rolldown

bump
gitignore
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 24, 2026

Deploy Preview for tsml-ui ready!

Name Link
🔨 Latest commit b29333a
🔍 Latest deploy log https://app.netlify.com/projects/tsml-ui/deploys/69cfe2ce892daa0008b7cece
😎 Deploy Preview https://deploy-preview-507--tsml-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joshreisner
Copy link
Copy Markdown
Contributor

thanks for taking that on. i think we'll need a virtualization replacement for infinite scroller - or at least test performance with 5,000+ meetings. what's oiaa-direct using now @SIA-WEBSUP ?

@joshreisner
Copy link
Copy Markdown
Contributor

maybe we should look at https://github.com/bvaughn/react-window

@pjaudiomv
Copy link
Copy Markdown
Collaborator Author

pjaudiomv commented Mar 24, 2026

maybe we should look at https://github.com/bvaughn/react-window

I attempted to use @tanstack/react-virtual
https://tanstack.com/virtual/latest

@joshreisner
Copy link
Copy Markdown
Contributor

thanks for adding virtualization!

on first load i'm not seeing the full screen get filled up - i think that could be a CSS problem.

Screenshot 2026-04-03 at 7 58 07 AM

the simplest fix might be to bump up the meetingsPerPage to 25

@pjaudiomv
Copy link
Copy Markdown
Collaborator Author

hm im not seeing that, are you seeing it here ? https://deploy-preview-507--tsml-ui.netlify.app/tests/aasanjose.html either way I am going to bump it to 25 that seems like good number anyway

update lock
@pjaudiomv
Copy link
Copy Markdown
Collaborator Author

done!

Copy link
Copy Markdown
Contributor

@joshreisner joshreisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

i didnt check the deploy preview, just locally with latest mac safari

@joshreisner joshreisner merged commit ef9cecc into code4recovery:main Apr 3, 2026
6 checks passed
@pjaudiomv pjaudiomv deleted the pj/react-19 branch April 3, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants