Closed
Conversation
5d67b26 to
161bb21
Compare
…StreakService dev_dependencies: firebase_core_platform_interface ^5.0.0 — setupFirebaseCoreMocks() fake_cloud_firestore ^3.0.0 — in-memory Firestore firebase_auth_mocks ^0.14.0 — MockFirebaseAuth / MockUser test/widget_test.dart rewrites the broken placeholder test with: - setupFirebaseMocks() in setUpAll so Firebase.initializeApp() succeeds - Smoke test: Splash/loading widget renders without crash - UserRepository tests: signUp writes displayName, getDisplayName reads it, returns null for unknown uid, isSignedIn false when no user - StreakService logic tests: first claim sets streak to 1; same-day call is idempotent (does not reset streak) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
161bb21 to
c3fe28f
Compare
Owner
Author
|
All changes from this branch have been implemented in subsequent commits on master — this PR is superseded and no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/widget_test.dartto usefake_cloud_firestore,firebase_auth_mocks, andfirebase_core_platform_interfaceso tests run without real FirebaseUserRepositoryandStreakServiceFiles changed
test/widget_test.dart— mocked Firebase setup + unit testspubspec.yaml— adds dev dependencies:firebase_core_platform_interface ^5.0.0,fake_cloud_firestore ^3.0.0,firebase_auth_mocks ^0.14.0Merge notes
feature/phase4-polish(pubspec.yamldev dependencies).Both modify
dev_dependencies. Resolution: keepflutter_lintsfrom phase4-polish; add test mocks from this branch.