fix(tui): rank slash command prefixes#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sessioselects/sessionsbefore/session/sessionmatching ahead of longer commandsRoot Cause
The editor autocomplete list showed both
sessionandsessions, but the fuzzy result order highlightedsessionfor/sessio. Pressing Enter accepted and submitted the highlighted singular command, so users saw session stats instead of opening the sessions HUD.Validation
node --test --import tsx test/autocomplete-slash.test.tsfailed withactual: [ session, sessions ]node --test --import tsx test/autocomplete-slash.test.tsnode --test --import tsx test/autocomplete.test.ts test/autocomplete-slash.test.tsnpm run checknpm --prefix packages/tui run build && npm --prefix packages/coding-agent run build/sessio; autocomplete selectedsessions; Enter invoked session-observer instead of/sessionSummary by cubic
Fixes slash-command autocomplete ranking in
packages/tuiso typing/sessioselectssessionsbeforesession. Exact/sessionstill ranks first.Bug Fixes
Refactors
packages/tui/src/slash-command-autocomplete.tsand wired intosrc/autocomplete.ts.packages/tui/test/autocomplete-slash.test.ts.Written for commit 4ce014c. Summary will update on new commits. Review in cubic