Conversation
…w to retryable Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
Bugsnag reports SubmitIntentError.StaleState errors with reason "race detected: cached balance version is stale". This is a server-side optimistic version lock — the client sends no balance version. When concurrent intents advance the version before the DB transaction commits, the check fails and the transaction rolls back (no nonces consumed). - Add isRaceCondition property to StaleState, matching the "race detected:" prefix — the only StaleState variant safe to blindly retry - Wrap submitIntent in retryableOrThrow with retryIf narrowed to race conditions only (other StaleState reasons like stale exchange rates, closed accounts, or claimed gift cards require client-side state refresh and would fail identically on retry) - Move gift-card-claimed Bugsnag suppression from InternalTransactionRepository to ReceiveGiftCardTransactor where the context-specific handling belongs Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
force-pushed
the
fix/retry-submit-intent-on-stale-state-race
branch
from
3794ab0 to
99b0c01
Compare
bmc08gt
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.