-
Notifications
You must be signed in to change notification settings - Fork 11
Security: pin GitHub Actions to SHA hashes #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |||||
| - name: Jira Login | ||||||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||||||
| id: login | ||||||
| uses: atlassian/gajira-login@v2.0.0 | ||||||
| uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0 | ||||||
| env: | ||||||
| JIRA_BASE_URL: ${{ secrets.JIRA_BASE_URL }} | ||||||
| JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }} | ||||||
|
|
@@ -27,7 +27,7 @@ jobs: | |||||
| - name: Jira Create issue | ||||||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||||||
| id: create_jira_issue | ||||||
| uses: atlassian/gajira-create@v2.0.1 | ||||||
| uses: atlassian/gajira-create@c0a9c69ac9d6aa063fed57201e55336ada860183 # v2.0.1 | ||||||
| with: | ||||||
| project: ${{ secrets.JIRA_PROJECT }} | ||||||
| issuetype: ${{ secrets.JIRA_ISSUE_TYPE }} | ||||||
|
|
@@ -53,7 +53,7 @@ jobs: | |||||
|
|
||||||
| - name: Update GitHub issue | ||||||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||||||
| uses: actions/github-script@v2.0.0 | ||||||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK The SHA hash
Suggested change
|
||||||
| env: | ||||||
| JIRA_ISSUE_NUMBER: ${{ steps.create_jira_issue.outputs.issue }} | ||||||
| GITHUB_ORIGINAL_TITLE: ${{ github.event.issue.title }} | ||||||
|
|
@@ -78,7 +78,7 @@ jobs: | |||||
|
|
||||||
| - name: Add comment after sync | ||||||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||||||
| uses: actions/github-script@v2.0.0 | ||||||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||||||
| with: | ||||||
| github-token: ${{secrets.GITHUB_TOKEN}} | ||||||
| script: | | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |||||
| - name: Jira Login | ||||||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||||||
| id: login | ||||||
| uses: atlassian/gajira-login@v2.0.0 | ||||||
| uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0 | ||||||
| env: | ||||||
| JIRA_BASE_URL: ${{ secrets.JIRA_BASE_URL }} | ||||||
| JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }} | ||||||
|
|
@@ -27,7 +27,7 @@ jobs: | |||||
| - name: Jira Create issue | ||||||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||||||
| id: create_jira_issue | ||||||
| uses: atlassian/gajira-create@v2.0.1 | ||||||
| uses: atlassian/gajira-create@c0a9c69ac9d6aa063fed57201e55336ada860183 # v2.0.1 | ||||||
| with: | ||||||
| project: ${{ secrets.JIRA_PROJECT }} | ||||||
| issuetype: ${{ secrets.JIRA_ISSUE_TYPE }} | ||||||
|
|
@@ -53,7 +53,7 @@ jobs: | |||||
|
|
||||||
| - name: Change Title | ||||||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||||||
| uses: actions/github-script@v2.0.0 | ||||||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK The commit SHA
Suggested change
|
||||||
| env: | ||||||
| JIRA_ISSUE_NUMBER: ${{ steps.create_jira_issue.outputs.issue }} | ||||||
| GITHUB_ORIGINAL_TITLE: ${{ github.event.issue.title }} | ||||||
|
|
@@ -70,7 +70,7 @@ jobs: | |||||
|
|
||||||
| - name: Add comment after sync | ||||||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||||||
| uses: actions/github-script@v2.0.0 | ||||||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||||||
| with: | ||||||
| github-token: ${{secrets.GITHUB_TOKEN}} | ||||||
| script: | | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 HIGH RISK
The SHA hash
6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45points tov3.0.0ofactions/github-script, whereas the comment and requirements specifyv2.0.0. This upgrade introduces breaking changes to the Octokit client (e.g.,github.issuesvsgithub.rest.issues) that will break the scripts used in this workflow.