Skip to content

Improve onboarding condition messages for better diagnostics#298

Merged
notandy merged 1 commit intomainfrom
improve-onboarding-condition-messages
May 4, 2026
Merged

Improve onboarding condition messages for better diagnostics#298
notandy merged 1 commit intomainfrom
improve-onboarding-condition-messages

Conversation

@notandy
Copy link
Copy Markdown
Contributor

@notandy notandy commented May 4, 2026

Instead of the generic "Onboarding not started" message, the Ready condition now reports the specific reason: lifecycle management being disabled or nova-compute not having registered the hypervisor yet (missing HypervisorID/ServiceID). This helps operators quickly identify root causes like DNS or RabbitMQ connectivity issues.

Summary by CodeRabbit

  • Improvements

    • Hypervisor onboarding status messages now provide context-specific guidance based on lifecycle configuration and service availability state, offering clearer information about what's needed rather than generic messaging.
  • Tests

    • Expanded test coverage for onboarding status conditions across different configuration scenarios.

Instead of the generic "Onboarding not started" message, the Ready
condition now reports the specific reason: lifecycle management being
disabled or nova-compute not having registered the hypervisor yet
(missing HypervisorID/ServiceID). This helps operators quickly identify
root causes like DNS or RabbitMQ connectivity issues.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 837fbb9f-bf2a-442b-a5b1-345f4fb3867c

📥 Commits

Reviewing files that changed from the base of the PR and between d4ba93c and 7c35a1e.

📒 Files selected for processing (2)
  • internal/controller/ready/controller.go
  • internal/controller/ready/controller_test.go
 _______________________________________
< For a good time, call 1-800-COD-RABT. >
 ---------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-onboarding-condition-messages

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{"name":"HttpError","status":502,"request":{"method":"PATCH","url":"https://api.github.com/repos/cobaltcore-dev/openstack-hypervisor-operator/issues/comments/4372447695","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\nNo actionable comments were generated in the recent review. 🎉\n\n<details>\n<summary>ℹ️ Recent review info</summary>\n\n<details>\n<summary>⚙️ Run configuration</summary>\n\n**Configuration used**: defaults\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `837fbb9f-bf2a-442b-a5b1-345f4fb3867c`\n\n</details>\n\n<details>\n<summary>📥 Commits</summary>\n\nReviewing files that changed from the base of the PR and between d4ba93cdee125d322dd5d5928bc17b8233fdef1c and 7c35a1e51fa202fff11c18b473ccad2d34fb4b87.\n\n</details>\n\n<details>\n<summary>📒 Files selected for processing (2)</summary>\n\n* `internal/controller/ready/controller.go`\n* `internal/controller/ready/controller_test.go`\n\n</details>\n\n</details>\n\n---\n\n\n<!-- walkthrough_start -->\n\n<details>\n<summary>📝 Walkthrough</summary>\n\n## Walkthrough\n\nThe PR enhances `ComputeReadyCondition` to generate context-specific failure messages when onboarding has not started, by checking lifecycle configuration and hypervisor ID availability instead of always returning a static message. Test coverage is expanded with three new cases covering each message variant.\n\n## Changes\n\n**Diagnostic Message Improvement**\n\n| Layer / File(s) | Summary |\n|---|---|\n| **Core Logic** <br> `internal/controller/ready/controller.go` | When `onboardingCondition` is `nil`, the returned `Ready=False` message is now conditional: mentions lifecycle disabled if `Spec.LifecycleEnabled` is false; mentions waiting for nova-compute if IDs are missing; otherwise defaults to generic \"Onboarding not started\". |\n| **Test Coverage** <br> `internal/controller/ready/controller_test.go` | Test suite expanded with three distinct cases for the conditional messaging logic: lifecycle disabled, lifecycle enabled with missing IDs, and lifecycle enabled with IDs present. Generic fallback test removed. |\n\n## Estimated code review effort\n\n🎯 2 (Simple) | ⏱️ ~10 minutes\n\n## Possibly related PRs\n\n- cobaltcore-dev/openstack-hypervisor-operator#286: Modifies the same `ComputeReadyCondition` function and Ready condition logic that this PR extends with more detailed failure messaging.\n\n## Suggested reviewers\n\n- fwiesel\n\n## Poem\n\n> 🐰 *A message twice refined shall speak more clear,*  \n> *No generic murmurs when the cause is near!*  \n> *Lifecycle halted? Nova waiting still?*  \n> *The ready condition now bends to thy will.* ✨\n\n</details>\n\n<!-- walkthrough_end -->\n\n<!-- pre_merge_checks_walkthrough_start -->\n\n<details>\n<summary>🚥 Pre-merge checks | ✅ 5</summary>\n\n<details>\n<summary>✅ Passed checks (5 passed)</summary>\n\n|         Check name         | Status   | Explanation                                                                                                                                                                                             |\n| :------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n|      Description Check     | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled.                                                                                                                                             |\n|         Title check        | ✅ Passed | The title 'Improve onboarding condition messages for better diagnostics' directly and clearly reflects the main change: making onboarding condition messages more specific and helpful for diagnostics. |\n|     Docstring Coverage     | ✅ Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.                                                                                                                    |\n|     Linked Issues check    | ✅ Passed | Check skipped because no linked issues were found for this pull request.                                                                                                                                |\n| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request.                                                                                                                                |\n\n</details>\n\n<sub>✏️ Tip: You can configure your own custom pre-merge checks in the settings.</sub>\n\n</details>\n\n<!-- pre_merge_checks_walkthrough_end -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing Touches</summary>\n\n<details>\n<summary>📝 Generate docstrings</summary>\n\n- [ ] <!-- {\"checkboxId\": \"7962f53c-55bc-4827-bfbf-6a18da830691\"} --> Create stacked PR\n- [ ] <!-- {\"checkboxId\": \"3e1879ae-f29b-4d0d-8e06-d12b7ba33d98\"} --> Commit on current branch\n\n</details>\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Commit unit tests in branch `improve-onboarding-condition-messages`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n<!-- announcements_start -->\n\n> [!TIP]\n> <details>\n> <summary>💬 Introducing Slack Agent: The best way for teams to turn conversations into code.</summary>\n> \n> [Slack Agent](https://www.coderabbit.ai/agent) is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.\n> \n> - Generate code and open pull requests\n> - Plan features and break down work\n> - Investigate incidents and troubleshoot customer tickets together\n> - Automate recurring tasks and respond to alerts with triggers\n> - Summarize progress and report instantly\n> \n> Built for teams:\n> \n> - **Shared memory** across your entire org—no repeating context\n> - **Per-thread sandboxes** to safely plan and execute work\n> - **Governance built-in**—scoped access, auditability, and budget controls\n> \n> One agent for your entire SDLC. Right inside Slack.\n> \n> 👉 [Get started](https://agent.coderabbit.ai/)\n> \n> </details>\n\n<!-- announcements_end -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=cobaltcore-dev/openstack-hypervisor-operator&utm_content=298)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n<!-- review_rate_limit_status_start -->\n<sub>Review rate limit: 0/1 reviews remaining, refill in 60 minutes.</sub>\n<!-- review_rate_limit_status_end -->\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcAks174UvwYAvjOtPAYRAoYEeL4WGyIiGikyABm+HwCJLg0fBGpGPiI4gzIkAYAco45FFwATACcAByQlQCqNgAyXLB53IgcAPTDROqw2AIaTMzDTAJoHrhMFCRgShLD+NxkpWgMANZgsLK7FBJIWWA7ygQUw9zYHh7DzW2diJRcxbiYtPJKgBlfDYCgMEiQARUDAMWBceD+CiBdYJULhSJEMBMWLqeAJMBJFJpSCAJMIYM5SLgoTC4VxmNosMC/rhsEN+LsmQYAMJrah0dCcSANAAMDQAbGARQBWKUAFmgAEZpRw5S0OMqAFpGAAi0gYFHg3HiGA4BigNhI3A8B2kkFwsEhpHIhoYkAARAB5EJhCgRKKQX72P4UGi0d2QS1oAExOL4xLSYmQgDuE0gzCykMQuwY8HS8DdfMQCUQGnNkZI0fkOLjCUgqZegfwycga24WWpycdDsokA8edEsgYXnTmFSJDYGGpqAiKQEXnoWXr3cdfGKEjQ2JYTxokFgaGQQdkuVbJHGpUoAp7e7OlEuxb4AApmEhEJjIAAJW8XK4UHw64YgTvAsSH/ABKMsoDgSE4UwUgUGQSIaFiK98D3EgPG4Dk7iyRClCnPN5GRfBqQYNA2TtDM1kgABHbAC0ODxZAAGhQWEPGwf1olfbA7QcOF0GQHUqiBfg+BsFQ1FwABZABFGJyDESR1HkAJ5wnUtKgMCxIG5FgX2pIlx2QBwnBcIwqhItjh04gVABQCBRWHUdNE2MyBaGwa0C35e1HWsOwlEQA0jRNdBYnctCg2jehorxBIljY5DqSXAIiDWZJ4zLc0wEMAwTCgMhF3SHACGIMg7gFWZJyFXh+GEURxCkGRq0UZRVHULQdH0PLwCghBEOQTASsIZ0KvoKr2C4KgW1MhkXChFqlCodrNG0XQcqMHrTAMJDKAwJZ5gSXBkReShhj5AFDqnE6vAoDQiHwM13We7TLAAQR8MqXX5ehZuceR8GK2ComkIwAAM9P8PASCjAE9NxE0wabFtRqoGhkCorMczzAtIDB2HZAAXgAMSWL4kaMkkuzIYJ0T9d990PKz9lDAVHzBtFfS4+HaywQnCcDeAPDBiCYD8ynIQ3Q07UWL5FywMHYAkDQgRzDRugHBghy8ABRfb1NoJH/mXXJVzxpWVZZNkNC/c57yyf8keGc3laBK3SyAn8IUd9BqK+XBWMiC9o34YqlmTNBZGQNl32vVHcbBr0fQxAMgxZsN3Qp1zSA0SA3sbEizZrOKsF4fFDVweQPHwcZCwnRlo9hfcQdoLLzHe5Y7njZACF8yElGHZxqG70PIBIAAPdtWcXPgnnnXH2DxUHy0s8hIEfYox8njs6EeKZ+zdRfK/seAiH21l0rE9zRBtNGR+B0haDAzadOkzAB1KSBiaFyE3v2piABelAjAa3IMgB+dAuAAGoADswwwCKiMDrUoiIfoKCUKeS4JAWwkHSJkUMXBpJ0HgI4Awz13RGAgGAIwu0KD/yusdfAp0HgXVkAwm6lAAD66NNAPSei9HSH0vpjXsI4OaAMgbNzSEgye/wrx+QAFQKKsIaLIKlIAqkgN6OmXEmzUnTrvFQO9aDDDTtgBgEI6B0CUfaaQpEURUHgnIdAtBdHkBbBDbc0MCY8xLkjCeOYWQj3wYwA8dpqbUTBqrUQ6tNbaxIHrFQC4kaoDBukMmJAkaPgPF8UMGNs6QmqiPfs6RBzDkKWOUg1UoQkHfLOJJdAwKsQiZCEpZSRyoDIA0+gAg8B41tsBB8/5ALAW9jqI21EXwZQDNk5IlBcD5OSOOFyBESz1m0OIAMISwbrk3LMHcmSmlhXoC0vscTykITHvrBcxzID/kGtRXg0h2DrxyfMxZSYx50TJnjJOOj3xpxDBnEWudoI8DWJcUEPc7G+WoAoKQax6DXkADgEm9OYp2iMXUKE8kALMALgE9gIT7VUes5AawMxSBiuFNsNoIQ9PkD2L46ZMz2GxvmN0ZEvilk2q9POnc75rN7teAet9h5rMBlvKeYYr5zwPlc8Q4hl5QFXpCR8PCbgYCYowKR0gIIgMiHaCBtBoENBaPAhoSCUEMmlUwDBEL4DYLHngjshDiGkPIZQjaW0CrhQleRUqqM0ETSnFNNAM0xH/QWugtqUlOrrUMPlMWqBUBDX9SNcqaNKr6UmtfP4P9xqtShNXI4oizLyGcbamNHU1rdWML1GhU49oHRxIw5h51KyXRbRwu6fCyECMsKA9YMJ4IQNzdoDwiBPXUMVC0GBCDWhmgAOoTEiHjSGByfEJF5mDVi14ObJ3plEXxoV+aC2FjSTAAligtn2dDQaeMJZI1KIaAMWL4xLCYmaKAep0nPAWfaNCidtFcwBczIFdBM6QTucVRWrs1Ya1KVrcpiSDYpIyBk1i/tkBAYPW4sDzgwxcDaUhkcDJ9pVJeTOJA3TIPlh1hOkggcYMWzdtQa2AyfxDPGVfWDls2Me1GaBbjnT/CV0w7kbDfyQOp3w9PLgEc8RbKXLsrcUNdy9zWOefIfcbx21/GxSAlkNzrw4/bP8AFPaXDGXoyAx5qRoA3ELBpYFaNgrWBfcg9B8YdtkEjN9dYW2RF4j3NCFE8ZRmLKaSAhwJDMAkIqDQx74wRYSMBjFSNUwOjxqx1k7JSYMZ3VCPpe6iFLNIGhpsfYEikD4NeN8UQRz7DKGc/ISxIKmA9dlahO1G10ObUdbt7aqzsKYbdbhdj7qPT7RQnSg6wDDpgjqsdQtJ1dYMKakUYAADMio5Rmh8FgFFKjy7qM0Wlw90RAUEcMaEaepjmbmMsUoWgBKW0TwDjpnhoj1CQk6ePZCz36xpgdGsSE7i8Y+FwEjec+AjjIA3P2Wgw8AyeLUzDHzSWEhI1BLgHcJsouPkVGBM5iH4mjnIxOSjyB6kG1Yo+BoxPiNk86dcgUvTqRg1M7+YZlmQI+2cIU1875nwFOshxQKkBkUKc2dEEJKnb00DxUc42j4tuM/OR05AXSDa3Pub7SETyvhTnXhLS5E8Di4C1ci87eH9HgZe6LMFZclxg0h9D4thxYXUgCQ1AUaBIDxzdKi2TYYCXpT/fjyr6KLuxhLlvXFA1TwUroO17rwAyMf1wJw/MXhDAPQ0BmWgeVhgZ9KaUbPP9DCddrYmwqo803CMzQW1gOalB5puZWotsPPd/XmhW1qy1Y01o2omqq6hOHwFoIgTh9rsF0E4eneNdaICQBgQwLb0o0CKhINKRU6TRQNDwekRUioGAzoEHKGBW2LHRgaLQLbcp0gX4ELOpf3rHIGQn1PmfJAsHJnn3Xt1Imk8pwmwBQKQJwnCKIIcNPovrWgAN4GDtDuhIC2AABCHudAkM1UVgJQGcXA6SDGzESBHoSAnoCKhoriZA7oBBGGJB7otAsOz6mIekCK44B2+Q/8OWJANBkAiB7QyBtC9CXao2Z0rCI2zCk2vB/BAhyBBAfwHgxM2AsIJoiAvBioxBshyB6QyhSkJYy6DoOoTBx0mIahXAiCshAAviQZYZoR6JWhJCtIusiDQCou4JbjwbQUQfQYgLAKCB4LQBgd3rYLwYQV8HYQwZPjYMoUYQwG7C+kQIgNyI6EcLwcdLxBERELQNERgO4V4MkdAWkRQBkfQVkTkXqEFIaMaPGAUakV4eEfQf2BgIcHQD4MkMFvEbwc9BETaKULUYcJaA4MsGYZAAANokHtAyGyHuhQFHBVBoBsBdEVHBTVF1j9Huh2HTFNZshFElFaEegBI2jnzxhdH9H2CHBGi7D0BQB6RKCOFSSACYBMgAgEQLAGAF4FIB4KWuImbqzq3BsRMQIe6IXp4R6BHHQpiACfse6GouMP/P0fMYsVwAwfqFUSaBQlYZsXwYCcgbMYcIiaCe6HkYtoUVicgdsSMekYxjiQcZPEcWKhgF0WCgqiOAAOR+ABBBDR66L+YJhlZ2ghI5B5C9iFBnx4EFiICsnuTwBrBiBarGzlLOBaprDpBeBiA9ziyMjapwTeCjgXEBjcnvi8kuT8kYwsrZiiA4xujGyOiYQ6FfEhKinFAoLlAaBQlaHAmtRdHgkYCQlkkeiykJD5hEBgiglhHUnQmwmRBLAIkLGEksk8GAm2GAlTFAl4kElLHGEJG6QOLjjulbHuy7ERkemHFjjonImxHMGvq5nwSoCKgigigaANkACky4BYsAlyDgeCBYDqU4oKfkawdEMp8i6UfhARlyLQjZLZbp/pnpSg3pzgvpUQ+ZQJUZ8JKR+JcZXRjB5QJhUQahSZWJqZuJG5GZyJoCLR9AbRDghqG5K55JhZXAVJs5pZxxCQpxG55xlxbOog5ETKm8TRl5CEN5yA/+1EmQyh9AISDoqATwjYg5wWmg95HoIJC5EJy5s5a5MZp5W5yJgFrR7R0gb0cyyQ1UGJAhyZshx59hOFSJHonofSEqQITAuwukOq4Cd5s5FJRZL5dJZZJxyJZxiAFx3AVxNSZEYWAFkQQFPE4Sl4kAEF4U0F/UPAzwXxCFE2yFc5hJPpfpNJMJhocJ2F0BZ5HoOOno6QzFtwyROpiAxFXKiAZFSZJBAAuj0QeLgLYMsWiQJR6C0AIDAi/iKAwNKBYrQIFQ/ltrQE0DAjAnKOKGgDArOgFQwAlYlY/g0A0DvjAk0AlSKOFQIOKMfuKHKAwE0Hgk0CQDtmqIqDAu6e6L0Z5TYMSV0Q0HKNvuKC0FtvlSQIqLldKAlU0CKLlUldKOkOKIqFtltofi0OKKlYldKLvgFU0IVeKOVWvtKLNWgGgHKCQL1RNRvgwHVQYNYe/iAWARAXidPoASPr1MNJwtwH+SQAviyM9XAV6vAQ1R5VYE9bQG9LgJaH/lgfpOoHpMobgDQSKKdYmmmg9U9S9fyJwjdXoEAA= -->\n\n<!-- internal state end -->"},"request":{"retryCount":3,"signal":{},"retries":3,"retryAfter":16}},"response":{"url":"https://api.github.com/repos/cobaltcore-dev/openstack-hypervisor-operator/issues/comments/4372447695","status":502,"headers":{"content-length":"32","content-type":"application/json","date":"Mon, 04 May 2026 15:51:07 GMT","etag":"\"69f8a473-20\"","server":"github.com","vary":"Accept-Encoding, Accept, X-Requested-With","x-github-request-id":"4363:1831DF:1AA314C:6A2C237:69F8C061","x-ratelimit-limit":"15000","x-ratelimit-remaining":"14944","x-ratelimit-reset":"1777912241","x-ratelimit-resource":"core","x-ratelimit-used":"56"},"data":{"message":"Server Error"}}}

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/ready 71.93% (+2.70%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/ready/controller.go 71.93% (+2.70%) 57 (+5) 41 (+5) 16 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/ready/controller_test.go

@notandy notandy merged commit d35db2a into main May 4, 2026
7 checks passed
@notandy notandy deleted the improve-onboarding-condition-messages branch May 4, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants