removing the arm build as it takes 27mins

[mchristianl]

there is no arm support for the cloud-hypervisor driver in libvirt anyways

[anokfireball]

You will almost certainly have to remove it here as well or the makefile maker might bring it back unintentionally:

openstack-hypervisor-operator/Makefile.maker.yaml

Line 38 in 21376f5

platforms: "linux/amd64,linux/arm64"

[notandy]

You will almost certainly have to remove it here as well or the makefile maker might bring it back unintentionally:

openstack-hypervisor-operator/Makefile.maker.yaml

Line 38 in 21376f5

platforms: "linux/amd64,linux/arm64"

youre right, requesting change

[toanju]

Github has native arm build, don't use qemu and gain a speedup if you want to keep the ARM builds

[felix-kaestner]

Github has native arm build, don't use qemu and gain a speedup if you want to keep the ARM builds

You don't even need that. Go is able to cross-compile for different target platforms if you tell it to, meaning you can compile native arm64 binaries on amd64 and Docker can even support that through the $BUILDPLATFORM definition. See https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/

This reduced our workflow execution (building amd64 & arm64) from ~30min to ~4min in ironcore-dev/network-operator#180.

You will just have to teach go-m-m to make use of this in the generated Dockerfile.

[coderabbitai]

Warning

Rate limit exceeded

@notandy has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 56 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e31978ee-f58d-4f4e-9081-4e4aff48da31

📥 Commits

Reviewing files that changed from the base of the PR and between f567e3f and 7ebf0bb.

📒 Files selected for processing (2)

• .github/workflows/container-registry-ghcr.yaml
• Makefile.maker.yaml

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mchristianl-patch-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}