Skip to content

Remove edge tag and force AppVersion for image version #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notandy merged 1 commit into from
Apr 27, 2026
Merged

Remove edge tag and force AppVersion for image version #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/container-registry-ghcr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
name: Container Registry GHCR
"on":
push:
branches:
- main
tags:
- '*'
workflow_dispatch: {}
permissions:
contents: read
Expand All @@ -34,8 +34,6 @@ jobs:
with:
images: ghcr.io/${{ github.repository }}
tags: |
# https://github.com/docker/metadata-action#typeedge
type=edge
# https://github.com/docker/metadata-action#latest-tag
type=raw,value=latest,enable={{is_default_branch}}
# https://github.com/docker/metadata-action#typesemver
Expand Down
1 change: 0 additions & 1 deletion Makefile.maker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ githubWorkflow:
tagStrategy:
- latest
- semver
- edge
- sha
pushHelmChartToGhcr:
path: charts/kvm-node-agent
Expand Down
2 changes: 1 addition & 1 deletion charts/kvm-node-agent/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: kvm-node-agent
description: A Helm chart for Kubernetes
appVersion: 0.1.0
appVersion: latest
version: 0.1.12
type: application
3 changes: 1 addition & 2 deletions charts/kvm-node-agent/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ spec:
fieldPath: {{ .Values.controllerManager.manager.env.nodeLabelFieldPath }}
- name: KUBERNETES_CLUSTER_DOMAIN
value: {{ quote .Values.kubernetesClusterDomain }}
image: {{ .Values.controllerManager.manager.image.repository }}:{{ .Values.controllerManager.manager.image.tag
| default .Chart.AppVersion }}
image: {{ .Values.controllerManager.manager.image.repository }}:{{ .Chart.AppVersion }}
livenessProbe:
httpGet:
path: /healthz
Expand Down
Loading