Skip to content

Remove logs that were for debug#18

Merged
valeryia-hurynovich merged 1 commit intomasterfrom
remove-logs-for-debug
Apr 16, 2026
Merged

Remove logs that were for debug#18
valeryia-hurynovich merged 1 commit intomasterfrom
remove-logs-for-debug

Conversation

@valeryia-hurynovich
Copy link
Copy Markdown
Collaborator

@valeryia-hurynovich valeryia-hurynovich commented Apr 16, 2026

Summary by CodeRabbit

  • Refactor
    • Removed verbose debug and informational logging from image update and profile reconciliation components to enhance operational log clarity and reduce noise.
    • Simplified internal helper function signatures by removing unnecessary parameters, improving code organization while preserving error handling functionality.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Warning

Rate limit exceeded

@valeryia-hurynovich has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 53 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0f1f358c-62a0-4aee-be1c-0762d99cba4c

📥 Commits

Reviewing files that changed from the base of the PR and between 196d3de and e135e7c.

📒 Files selected for processing (2)
  • cloudprofilesync/imageupdater.go
  • controllers/managedcloudprofile_controller.go
📝 Walkthrough

Walkthrough

This PR removes verbose logging statements from image filtering and cloud profile reconciliation logic, and refactors multiple function signatures across two files to eliminate logr.Logger parameters while preserving error handling and core functionality.

Changes

Cohort / File(s) Summary
Image Updater Logging Cleanup
cloudprofilesync/imageupdater.go
Removed informational/debug logs from filterImages and ImageUpdater.Update including start/finish messages, validation details, and provider invocation logs. Changed semver parsing to discard parsed result (_) while maintaining parse-and-skip behavior.
Controller Logging & Signature Refactoring
controllers/managedcloudprofile_controller.go
Removed verbose logging from reconciliation, garbage collection, and version management functions. Removed logr.Logger parameter from reconcileGarbageCollection, getReferencedVersions, keppelURL, registryBaseURL, and splitKeppelRepository function signatures; updated all call sites accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • adziauho

Poem

🐰 Hop, hop! The logs take flight,
Cleaner code, oh what a sight!
Logger gone from every frame,
Errors flow through—still the same.
Verbose noise now set to rest,
Simple functions, truly best!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove logs that were for debug' directly and accurately describes the main change: removal of debug/informational logging statements across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-logs-for-debug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/cloud-profile-sync/cloudprofilesync 83.33% (-1.67%) 👎
github.com/cobaltcore-dev/cloud-profile-sync/controllers 59.02% (+1.83%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/cloud-profile-sync/cloudprofilesync/imageupdater.go 85.29% (-3.17%) 34 (-18) 29 (-17) 5 (-1) 👎
github.com/cobaltcore-dev/cloud-profile-sync/controllers/managedcloudprofile_controller.go 59.02% (+1.83%) 205 (-80) 121 (-42) 84 (-38) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@valeryia-hurynovich valeryia-hurynovich merged commit 813b050 into master Apr 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants