Skip to content

Refactor logic of referenced versions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valeryia-hurynovich merged 1 commit into from
Apr 15, 2026
Merged

Refactor logic of referenced versions #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions controllers/managedcloudprofile_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,32 +305,6 @@ func (r *Reconciler) getReferencedVersions(ctx context.Context, cloudProfileName
referenced := make(map[string]struct{})
log.V(1).Info("retrieving referenced versions", "cloudProfile", cloudProfileName, "image", imageName)

var cp gardenerv1beta1.CloudProfile
if err := r.Get(ctx, types.NamespacedName{Name: cloudProfileName}, &cp); err != nil {
log.Error(err, "failed to get CloudProfile")
return nil, fmt.Errorf("failed to get CloudProfile: %w", err)
}

if cp.Spec.ProviderConfig != nil {
var cfg providercfg.CloudProfileConfig
if err := json.Unmarshal(cp.Spec.ProviderConfig.Raw, &cfg); err != nil {
log.Error(err, "failed to unmarshal ProviderConfig")
return nil, fmt.Errorf("failed to unmarshal ProviderConfig: %w", err)
}
for _, img := range cfg.MachineImages {
if img.Name != imageName {
continue
}
for _, v := range img.Versions {
if idx := strings.LastIndex(v.Image, ":"); idx != -1 {
version := v.Image[idx+1:]
referenced[version] = struct{}{}
log.V(1).Info("found referenced version in ProviderConfig", "version", version)
}
}
}
}

shootList := &gardenerv1beta1.ShootList{}
if err := r.List(ctx, shootList, client.InNamespace(metav1.NamespaceAll)); err != nil {
log.Error(err, "failed to list Shoots")
Expand Down
Loading