Open
Conversation
brookslogan
reviewed
Apr 20, 2026
|
|
||
| # NA checks for essential keys | ||
| has_na_geo <- anyMissing(res$geo_value) | ||
| has_na_time <- anyMissing(res$time_value) |
Contributor
There was a problem hiding this comment.
todo: anyMissing is sort of deprecated; replace with vctrs::vec_any_missing or anyNA; vctrs one is a bit more general, which might make it easier to generalize the types we accept for geo & time values later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
/styleto check the style and fix any issues./documentto check the package documentation and fix any issues./preview-docsto preview the docs.process.
Join method for
epi_dfHere's how
*_join.epi_dfperforms across different scenarios:epi_df:epi_dfobjects with different keys correctly updates the combinedother_keysmetadata.epi_dfis preserved.*_typeinternal attributes do not match, it issues a warning.epi_dfobjects are not joined bygeo_valueortime_value.NAvalues into key columns. A warning is issued suggesting the use ofinner_join.cross_join()is used.I also added an internal
force_metato easily adjustgeo_typeandtime_typewhen using a pipe, as shown in the example below.Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
epi_dfjoins to data frames with richer keys yields invalidepi_df#671