Round out dplyr&tidyr functionality for grouped epi_dfs#310
Draft
brookslogan wants to merge 2 commits intodevfrom
Draft
Round out dplyr&tidyr functionality for grouped epi_dfs#310brookslogan wants to merge 2 commits intodevfrom
epi_dfs#310brookslogan wants to merge 2 commits intodevfrom
Conversation
Motivation:
* In the current `c("epi_df", "grouped_df", "tbl_df", "tbl", "data.frame")`
approach without many `epi_df` methods, there are several `grouped_df` methods
that will drop the `epi_df` class.
* `tbl_sum.grouped_df` expects `grouped_df` to be in front / a subclass of the
"base" class for ungrouped data.
So move to make grouped `epi_df`s have class vector `c("grouped_edf",
"grouped_df", "epi_df", "tbl_df", "tbl", "data.frame")`, and implement a handful
of methods for `grouped_edf` to try to keep around `epi_df`-ness and
`grouped_edf`-ness when appropriate. Replace `reclass` with multiple similar
functions to facilitate this change.
brookslogan
changed the base branch from
dev
to
lcb/make_epix_slide_more_like_reframe
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress and is currently buggy. See related thread around this comment for bugs and potential ways forward.