Fix: preserve nil values in MapToMap conversion#8
Merged
Conversation
Owner
|
PR 的新增的测试用例太过于冗余了,我精简了一下。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题描述
在使用
conv.MustConvertType()转换包含nil值的 map 时,这些键值对会完全丢失。例如:
根本原因
在
MapToMap函数中,当dstVal是nil时:reflect.ValueOf(dstVal)返回零值reflect.ValueSetMapIndex方法接收零值reflect.Value时会删除该键nil值的键值对被删除而不是被保留解决方案
dstVal是nil时,使用reflect.Zero(dstValueType)创建一个表示nil的有效reflect.Valuenil值而不是删除键测试
TestConv_mapToMapWithNilValues测试用例验证修复效果影响范围
MapToMap函数处理nil值的行为