Add support for admin-only evaluation feedback.#1642
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1642 +/- ##
==========================================
+ Coverage 54.67% 54.72% +0.05%
==========================================
Files 335 335
Lines 27356 27400 +44
==========================================
+ Hits 14956 14995 +39
- Misses 12400 12405 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
prandla
left a comment
There was a problem hiding this comment.
looks like a neat feature, thanks.
imo it'd make more sense to have the admin details be after the public details column though. did you have any reason for having them in this order?
No reason :-) |
8cbb139 to
0847ea5
Compare
prandla
left a comment
There was a problem hiding this comment.
also, please update the return type annotations on the functions you changed. (do you not use LSP when developing, or do you just ignore all the type errors out of habit?)
Admin-only feedback is either automatically generated by the white diff comparison step, or by outputting an additional line on stderr from the checker that starts with `ADMIN_MESSAGE:`.
I did not have a LSP set up for Python :-) now I do |
Admin-only feedback is either automatically generated by the white diff comparison step, or by outputting an additional line on stderr from the checker that starts with
ADMIN_MESSAGE:.