New wiring for TrackletProcessorDisplaced#7
New wiring for TrackletProcessorDisplaced#7cgsavard wants to merge 2 commits intocms-data:masterfrom
Conversation
|
A new Pull Request was created by @cgsavard for branch master. @aandvalenzuela, @aloeliger, @cmsbuild, @epalencia, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
Pull request #7 was updated. |
|
@cms-sw/l1-l2 is this still needed? |
|
To be fully honest, I had forgotten this PR. I don't know if it is still needed. @cgsavard? |
|
Yes this is still needed, it was tested in this PR here. |
|
Hi, this PR seems to be paused for no apparent reason since months? |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/46963/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
This PR has now taken 7 months to merge, despite not needing any corrections. I'd hoped it would go into CMSSW 15_1_0_pre4, but it's too late. Can we get it into pre5? Thanks. |
|
Can I ping this again? We've been waiting almost a year to get this merged, despite there being no review comments and it passing all checks. |
|
Once @cms-sw/l1-l2 signs we can merge |
|
+externals good to go from external point of view |
|
please test using full cmssw lets refresh the tests |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/49757/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
Can we merge this now please? |
|
+externals I see https://github.com/search?q=repo%3Acms-sw%2Fcmssw%20L1Trigger%2FTrackFindingTracklet%2Fdata&type=code contains ref to these files. I am not sure if there is any workflow which one can run to test the updated data files |
|
The python files you refer to are use by the displaced L1 tracking, so running this would check all OK. This was done already when the PR was first created, but as that was 14 months ago, it might be wise if I rerun it. |
|
@aehart Your PR #8 is already merged. We originally foresaw that Claire Savard's PR would be merged before yours. But as she changed memorymodules_hourglassExtendedAllCombined.dat + wires_hourglassExtendedAllCombined.dat and your PR didn't touch these, I don't think there should be any clash. Unfortunately, your PR has not yet gone into a daily release, such as /cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el9_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2026-02-22-0000/external/el9_amd64_gcc13/data/L1Trigger/TrackFindingTracklet/data/ , so it's a bit painful running the L1 tracking to check that her PR and yours really don't clash. @smuzaffar any idea when Andrew's PR will go into a release? |
|
@tomalin , from externals point of we, we have already signed it. It can go in IB when @BenjaminRS @quinnanm can sign it for @cms-sw/l1-l2 |
6 participants
The changes in the wiring maps no longer allow duplicate triplet seeds to be created in the TrackletProcessorDisplaced. These changes were presented to the L1Tk group here and the same changes are going into the forked cmssw branch (PR here) until this PR goes through. A minor change for the prompt tracking is also made to no longer create duplicates of seed 6.