Add unit class to FlowerMD and allow using real units in Simulation runs#137
Open
marjanalbooyeh wants to merge 68 commits intocmelab:mainfrom
Open
Add unit class to FlowerMD and allow using real units in Simulation runs#137marjanalbooyeh wants to merge 68 commits intocmelab:mainfrom
marjanalbooyeh wants to merge 68 commits intocmelab:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
Author
|
Couple of issues that we need to look into:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 94.77% 95.04% +0.27%
==========================================
Files 26 27 +1
Lines 1970 2160 +190
==========================================
+ Hits 1867 2053 +186
- Misses 103 107 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Unit class to FlowerMD, which contains commonly used units from
unytpackage.With this change, all values with units in FlowerMD are formatted as
value * flower.Units.<unit>. For example, a temperature in Kelvin is300 * flowermd.Units.K.This PR also makes the following changes to the interface of run functions in
Simulationclass:kTis nowtemperature, which can handle both kT values (unitless) and temperature values with units.n_stepsvariable is now calledduration, which can be both a number (number of steps) or time length with units.ToDo: