avoid relying on implicit promotion of const fn calls#2
Merged
denisandroid merged 1 commit intoclucompany:masterfrom Dec 28, 2020
Merged
avoid relying on implicit promotion of const fn calls#2denisandroid merged 1 commit intoclucompany:masterfrom
denisandroid merged 1 commit intoclucompany:masterfrom
Conversation
Member
|
Interesting, good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are plans to change the rules for implicit promotion such that calls to
const fnare not implicitly promoted to'staticlifetime any more. A crater experiment showed that only very few crates would be affected by this change, and this is one of them.This PR adjusts the code to no longer rely on implicit promotion, by explicitly putting the result of the function call into a
constitem. Long-term, there will be the possibility of using inline const expressions instead, which will be more ergonomic.