Open
Conversation
Mirrors the existing claude-review.yml from the iOS-private and Android repos to enable automated code review on pull requests. Made-with: Cursor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
bryanboyko
added a commit
that referenced
this pull request
Mar 20, 2026
* Fix test failures after merge - environment config and DI container setup * • Implement server-side win/loss tracking matching Android architecture • Replace legacy client-side NURL/LURL firing with structured server payloads • Add comprehensive test suite validating critical business logic flows * Test new win loss service on all ad formats and confirm win notifs are sending for banner, interstitial, MREC, and native. Loss notifications aren't tested yet because more than one bid is needed for them to take effect. Add unit and integration tests for all ad formats * Compress verbose debug logs into single informative log line - Consolidated 5 separate debug logs in CLXTrackingFieldResolver into 1 concise log - Removed verbose key listings that weren't useful for debugging - Added checkmark indicators for device/geo object existence - Maintains essential debugging information while reducing log noise * Optimize CLXWinLossTracker logging for production readiness • Reduce log verbosity by 70% while maintaining diagnostic value • Focus on business outcomes (WIN/LOSS results) over implementation details * Eliminate redundant success logging between network and tracker layers • Remove duplicate success messages that create noise in logs • Keep only essential error logging for debugging network failures * Remove redundant logging noise from win/loss tracking system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-review.ymlGitHub Actions workflow, mirroring the existing setup in the iOS-private and Android reposANTHROPIC_API_KEYsecretTest plan
Made with Cursor