pkg/spanner - breaking - remove migration tableName parameter from API#51
Draft
fcostin wants to merge 1 commit intocloudspannerecosystem:masterfrom
Draft
pkg/spanner - breaking - remove migration tableName parameter from API#51fcostin wants to merge 1 commit intocloudspannerecosystem:masterfrom
fcostin wants to merge 1 commit intocloudspannerecosystem:masterfrom
Conversation
Refactor responsibility of setting the migration table name Previously pkg/spanner Client API expected caller to explicitly pass in the migration table name, except when doing a truncate operation, where the migration table name was hardcoded and the caller could not control it. BEWARE: this commit introduces a breaking change to the Client API and removes tableName. Instead, tableName can optionally be set when a Client is created. See: pkg/spanner/config.go Reworked cmd/ to use the new pkg/spanner API.
Author
|
beware: i haven't figured out how to get the test suite to run against a spanner emulator on my local machine, so i cannot confirm the test suite is passing on this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor responsibility of setting the migration table name
Previously pkg/spanner Client API expected caller to explicitly
pass in the migration table name, except when doing a truncate
operation, where the migration table name was hardcoded and the
caller could not control it.
BEWARE: this commit introduces a breaking change to the Client
API and removes tableName. Instead, tableName can optionally
be set when a Client is created. See: pkg/spanner/config.go
Reworked cmd/ to use the new pkg/spanner API.
WHAT
WHY
see: #50