use replace to avoid build failure#132
Open
sivchari wants to merge 1 commit intocloudspannerecosystem:masterfrom
Open
use replace to avoid build failure#132sivchari wants to merge 1 commit intocloudspannerecosystem:masterfrom
sivchari wants to merge 1 commit intocloudspannerecosystem:masterfrom
Conversation
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Collaborator
|
@sivchari thanks to your contributions! |
Contributor
|
Since there is no comment from the author, I will comment instead. My understanding is that this was a temporary bug that existed during the development of Go 1.25, and that discussions have confirmed it does not exist in any officially released version of Go. apstndb/gsqlutils#1 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Added replace directive.
WHY
Currently, wrench got the build failure since the xiter uses invalid syntax. (ref: spheric-cloud/xiter#1)
The pr referred above will correct it, but we don't know when it's merged.
So I added replace directive to avoid this error. Since, we've already had the flow to publish binary, it's not problem to have replace directive in itself.