Mentioned the mandatory condition regarding limits for RR#355
Open
agupta-cruiser wants to merge 2 commits intomainfrom
Open
Mentioned the mandatory condition regarding limits for RR#355agupta-cruiser wants to merge 2 commits intomainfrom
agupta-cruiser wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a clarifying note to the retention rules documentation explaining that at least one limit (Days, Count, or Size) must be greater than 0 for a retention rule to execute. This addresses a potential point of confusion for users configuring retention rules.
Changes:
- Added a Note component highlighting the mandatory condition that at least one limit must be greater than 0 for retention rules to function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
clairemcdyre
requested changes
Feb 27, 2026
Contributor
clairemcdyre
left a comment
clairemcdyre
left a comment
There was a problem hiding this comment.
Thanks for raising this Aryan - could you move this note to the bottom of the deletion logic section? https://docs.cloudsmith.com/artifact-management/retention-rules#the-deletion-logic
I'll approve it once that is change is made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.