Skip to content

feat: add dev warning for missing field definition labels in attribute-editor#4337

Draft
Who-is-PS wants to merge 2 commits intomainfrom
dev-v3-philosr-AWSUI-61432
Draft

feat: add dev warning for missing field definition labels in attribute-editor#4337
Who-is-PS wants to merge 2 commits intomainfrom
dev-v3-philosr-AWSUI-61432

Conversation

@Who-is-PS
Copy link
Member

Description

Adds a console warning via warnOnce when an AttributeEditor field definition is missing a label prop. The label is used as aria-label for the inputs in the column, so omitting it degrades the screen reader experience.

This change helps guide developers toward providing accessible labels without introducing a breaking change (making label required).

Related links, issue #, if available: AWSUI-61432

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (b0bfa53) to head (93e44b6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4337   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         897      897           
  Lines       26345    26352    +7     
  Branches     9517     9522    +5     
=======================================
+ Hits        25670    25677    +7     
+ Misses        669      632   -37     
- Partials        6       43   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant