fix: Add characterCountText to form field for improved screen reader support#4332
Open
avinashbot wants to merge 3 commits intomainfrom
Open
fix: Add characterCountText to form field for improved screen reader support#4332avinashbot wants to merge 3 commits intomainfrom
avinashbot wants to merge 3 commits intomainfrom
Conversation
181839c to
d0adbdd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4332 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 897 897
Lines 26342 26357 +15
Branches 9517 9522 +5
=======================================
+ Hits 25667 25682 +15
Misses 632 632
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apparently, NVDA/JAWS don't fare well when you update the accessible description of an input you're focused on after every keypress, and end up interrupting everything else, like the keypress announcements themselves.
This introduces a new string property,
characterCountText, whose updates are debounced for screen readers. This also means that only the updated section of the constraint text ("Character count: x/y") is announced when it changes.Related links, issue #, if available: AWSUI-61742
How has this been tested?
Added unit tests and a test util method.
Provisioning a Windows machine right now, but I'll also let our accessibility specialists take a crack at it before merging. But in the meantime, the code itself is reviewable.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.