Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ jobs:
strategy:
matrix:
include:
- title: "license-check"
command: "pnpm run check-licenses"
- title: "lint-check"
command: "pnpm lint"
- title: "type-check"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "Vulnerability Check"
name: "Vulnerability and License Check"

on:
pull_request:
Expand All @@ -21,10 +21,12 @@ jobs:
steps:
- name: "Checkout Repository"
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: "Run Vulnerability Check"
- name: "Run License and Vulnerability Check"
id: dep-review
uses: actions/dependency-review-action@3c4e3dcb1aa7874d2c16be7d79418e9b7efd6261 # v4.8.2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
fail-on-severity: high
allow-licenses: MIT, ISC, Apache-2.0, BSD-2-Clause, BSD-3-Clause, BSD-4-Clause, 0BSD, CC-BY-3.0, CC-BY-4.0, BlueOak-1.0.0, CC0-1.0, Python-2.0, Unlicense
repo-token: ${{ secrets.GITHUB_TOKEN }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Before submitting your pull request, please ensure your code passes the followin
- **Prettier**: Ensure your code is properly formatted by running `pnpm check-format`.
- **Title lint**: Ensure your title is following conventional commit format, for more details please check the [workflow](.github/workflows/ci-title-lint-check.yaml)
- **License Header**: Verify that every source file includes the correct license header as specified above.
- **Allowed Licenses**: Ensure that any dependencies added are compliant with the list of allowed licenses (see in `package.json`). Check with `pnpm check-licenses`.
- **Allowed Licenses**: Ensure that any dependencies added are compliant with the list of allowed licenses (see in `dependency-check.yaml`).
- **REUSE Compliance**: Ensure that your contributions are compliant with the [REUSE guidelines](./reuse/dep5).
- **Tests**: Make sure all tests pass. Run `pnpm test` at the root level to ensure your code didn't break other packages.

Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"lint": "turbo run lint",
"test": "turbo run test",
"typecheck": "turbo run typecheck",
"check-licenses": "npx license-checker-rseidelsohn --summary --excludePackages='spawndamnit@3.0.1' --excludePrivatePackages --onlyAllow 'MIT;ISC;Apache-2.0;BSD-2-Clause;BSD-3-Clause;BSD-4-Clause;CC-BY-3.0;CC-BY-4.0;BlueOak-1.0.0;CC0-1.0;0BSD;Python-2.0;BSD*;Unlicense'",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Unlicense really be allowed (as in old check)? I think it should be removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, by docs, we need to remove this.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why we introduce it. But I remember we had to introduce so some packages could go through...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule is "No license - no rights". So just want to understand the context here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learnt: Unlicense is an actual lisence. It’s categorised as FSF Free/Libre and OSI Approved for SPDX. I'll investigate further.

"cleanVite": "find . -type f -name 'vite.config.*.timestamp-*' -ls -delete 2>/dev/null",
"clean": "pnpm run cleanVite && turbo run clean && rm -rf node_modules",
"clean:cache": "turbo run clean:cache && rm -rf .turbo && rm -rf node_modules/.cache/turbo",
Expand All @@ -33,7 +32,6 @@
"@types/node": "24.3.2",
"eslint": "9.35.0",
"husky": "9.1.7",
"license-checker-rseidelsohn": "4.4.2",
"prettier": "3.6.2",
"turbo": "2.5.6",
"typescript": "5.9.2"
Expand Down
Loading
Loading