-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): remove license-checker-rseidelsohn and replace with GH action #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+17
−338
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5630d74
remove lisence check npm dep and introduce gh action
guoda-puidokaite affc1b0
remove lisence check npm dep and introduce gh action
guoda-puidokaite 0fda9ef
dep lisence check
guoda-puidokaite 5b40d3f
dep lisence check
guoda-puidokaite 7be26e2
fix syntax
guoda-puidokaite b2fbb21
fix syntax
guoda-puidokaite 2de887f
remove lisence check npm dep and introduce gh action
guoda-puidokaite 9d89514
fix syntax
guoda-puidokaite d93d71b
fix syntax
guoda-puidokaite ce7ae11
remove lisence check npm dep and introduce gh action
guoda-puidokaite f8044c8
remove lisence check npm dep and introduce gh action
guoda-puidokaite 6e4e277
remove lisence check npm dep and introduce gh action
guoda-puidokaite df63ef4
introduce unsupported lisence to test
guoda-puidokaite ea0f091
revert test
guoda-puidokaite 043bcd4
revert test
guoda-puidokaite a665000
revert test
guoda-puidokaite 7ca7c44
Merge branch 'main' into guoda-dep-lisence-check
guoda-puidokaite 2192a1d
update lock
guoda-puidokaite d179deb
add unsupported dep test
guoda-puidokaite 09098b7
revert licence test
guoda-puidokaite 529fa7a
spelling
guoda-puidokaite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
Unlicensereally be allowed (as in old check)? I think it should be removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, by docs, we need to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember why we introduce it. But I remember we had to introduce so some packages could go through...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rule is "No license - no rights". So just want to understand the context here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learnt:
Unlicenseis an actual lisence. It’s categorised asFSF Free/LibreandOSI ApprovedforSPDX. I'll investigate further.