fix(ISSUE-1833): make setup authz targets wrong cluster

[Zaggy21]

Description

This PR simplifies the authz make targets by overriding the ADMIN_CLUSTER env_var and using existing targets. It adds a dashboard config for authz cluster.
It updates the URL to access the demo org dashboard, the correct one is: http://demo.dashboard.localhost:<local-port>/.
It also removes the dependency image tag override from authz chart, so that it uses the appVersion for the greenhouse chart version.

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Related Tickets & Documents

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help
• Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

• 📜 README.md
• 🤝 Documentation pages updated
• 🙅 no documentation needed
• (if applicable) generated OpenAPI docs for CRD changes

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing unit tests pass locally with my changes

Summary by CodeRabbit

• Documentation

  • Updated local development dashboard access URL from localhost:5001 to demo.dashboard.localhost:5001 in setup documentation.

• Chores

  • Enhanced local development environment configuration for authorization-related setup and testing workflows.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR restructures authorization setup workflows by introducing authz-specific orchestration targets, adds a new Kubernetes configuration for dashboard deployment in the greenhouse-authz namespace, updates dashboard URL references from localhost:5001 to demo.dashboard.localhost:5001, and removes explicit image tag configuration in favor of chart defaults.

Changes

Cohort / File(s)	Summary
Authorization Setup Orchestration Makefile, hack/authz/authz.mk	Refactors setup-authz dependencies to invoke new setup-dashboard-authz and setup-demo-authz targets; introduces standardized ADMIN_CLUSTER context across e2e and demo workflows with updated target definitions and dependencies.
Dashboard Configuration & Deployment charts/authz/values.yaml, dev-env/ui.authz-config.yaml, internal/local/setup/dashboard.go	Adds new YAML configuration for cors-proxy and dashboard chart deployment in greenhouse-authz namespace; removes explicit image tag configuration; updates internal dashboard setup URL to use demo.dashboard.localhost.
Documentation docs/contribute/local-dev.md	Updates user-facing documentation to reflect new dashboard access URL from localhost:5001 to demo.dashboard.localhost:5001.

Poem

🐰 Authz targets align with care,
Demo cluster, namespaces fair,
Dashboard dashboards, URLs bright,
Charts compose in greenhouse light,
Setup flows dance left and right! 🎯

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the fix for issue 1833 related to authz Makefile targets, though it has a grammatical issue ('targets wrong cluster' is unclear).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The PR description covers all required template sections with clear explanations of changes, appropriate type selection, issue linkage, and checklist completion.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/make-setup-authz-targets-wrong-cluster

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[abhijith-darshan]

Have you tried setting env inside the authz.mk invoke commands like

e2e-local-authz:
ADMIN_CLUSTER=greenhouse-authz-admin make e2e-local

This way no change is necessary in the root Makefile?

[Zaggy21]

Have you tried setting env inside the authz.mk invoke commands like

e2e-local-authz:
ADMIN_CLUSTER=greenhouse-authz-admin make e2e-local

This way no change is necessary in the root Makefile?

Now it's also not necessary and by using target-specific variables with dependency approach there's no need to run a recursive make:

.PHONY: e2e-local-authz
e2e-local-authz: ADMIN_CLUSTER := greenhouse-authz
e2e-local-authz: SCENARIO := authz
e2e-local-authz: e2e-local

[abhijith-darshan]

@Zaggy21 let’s wait till this PR gets merged?
#1871

As I changed quite a bit of the chart values shape and the dev-env values file..

[abhijith-darshan]

We can improve the makefile simplification as a follow up. Let’s not hold this PR for long