Improve acceptance tests#782
Merged
peanball merged 15 commits intocloudfoundry:masterfrom Apr 9, 2025
Merged
Conversation
BPM release and version is now specified in haproxy manifest. There is no need to handle it in a custom way.
This is to avoid rebuilding image on every local run.
Put common functions into a file that can be sourced by scripts that need them.
When developing, do not check for clean repository.
Run only on one node when specifying focus. This is to simplifly debug. co-authored-by: Alexander Lais <alexander.lais@sap.com>
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
peanball
reviewed
Apr 2, 2025
Contributor
peanball
left a comment
peanball
left a comment
There was a problem hiding this comment.
Added some articles to the text, will try out on the dev-box. But it looks very promising. I like the name KEEP_RUNNING and that it auto-enables when you run a test in focus mode.
peanball
reviewed
Apr 7, 2025
peanball
previously approved these changes
Apr 7, 2025
Contributor
peanball
left a comment
peanball
left a comment
There was a problem hiding this comment.
some very minor comments still left. Everything should work as is though.
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
When doing manual debug, we want bosh container to keep running, so that we can easily run multiple focused tests.
Creating VMs with docker-cpi, when running in docker, is I/O heavy and slow. There is no need for 5 compilation VMs, there is not much to compile in this release. Reduce to 2 to speed up deployment (and overall acceptance tests run time).
Mouting ext4 scratch inside docker means that internal docker can run overlay2 filesystem, meaning it doesn't need to copy data on container creation like with VFS.
Reflect updated scripts and describe new persistence options.
Co-authored-by: Alexander Lais <Alexander.lais@me.com>
mtekel
force-pushed
the
improve-acceptance-tests
branch
2 times, most recently
from
084ac4f to
21ae00c
Compare
peanball
previously approved these changes
Apr 8, 2025
Contributor
peanball
left a comment
peanball
left a comment
There was a problem hiding this comment.
very minor nit about the (pre-existing) use of a weird manifest trimming thing by counting lines, instead of head -n -4 to cut the last 4 lines.
SC2086 (info): Double quote to prevent globbing and word splitting. and similar. Note that in some cases scripts do depend on various side effect, so not all SC recommendations are applied.
mtekel
force-pushed
the
improve-acceptance-tests
branch
from
21ae00c to
d02c411
Compare
peanball
approved these changes
Apr 9, 2025
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tech debt on acceptance tests:
Improve runtime/user friendliness for development and debug:
Update docs.