Skip to content

CI: fix build-docker-args#178

Merged
aramprice merged 1 commit into
windows-2019from
ci-fix-docker-args
May 8, 2026
Merged

CI: fix build-docker-args#178
aramprice merged 1 commit into
windows-2019from
ci-fix-docker-args

Conversation

@aramprice
Copy link
Copy Markdown
Member

@aramprice aramprice commented May 8, 2026

Fixes:

Failed to parse build_args_file (docker-build-args/docker-build-args.json)

See similar change: cloudfoundry/bosh@29b4084

Fixes:
```
Failed to parse build_args_file (docker-build-args/docker-build-args.json)
```
Copilot AI review requested due to automatic review settings May 8, 2026 22:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Review Change Stack

Walkthrough

This PR updates the jq asset-selection filter in the CI build script that computes the golangci-lint installation URL. The regex pattern was tightened by adding an end-of-string anchor ($) to the filename match, changing from ...tar.gz to ...tar.gz$. This ensures the pattern matches only the exact expected golangci-lint Linux amd64 tarball filename, not partial or similar filenames.

Suggested reviewers

  • selzoc
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'CI: fix build-docker-args' is directly related to the changeset, which fixes a build-docker-args script issue by updating a jq filter for computing the golangci_lint_install_url.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly explains the CI failure being fixed and references a similar change in the same repository, making it directly relevant to the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-fix-docker-args

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aramprice aramprice requested review from a team, a-hassanin and colins and removed request for a team May 8, 2026 22:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI task that generates Docker build arguments to correctly select the golangci-lint release asset URL, preventing invalid docker-build-args.json output that Concourse fails to parse.

Changes:

  • Tighten the jq match(...) pattern for golangci-lint assets by anchoring it to the end of the filename ($) to avoid unintended matches.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 16 to +17
golangci_lint_install_url="$(curl -H "Authorization: token ${GITHUB_ACCESS_TOKEN}" -s https://api.github.com/repos/golangci/golangci-lint/releases/latest \
| jq -r '.assets[] | select(.name | match("golangci-lint-[0-9]+.[0-9]+.[0-9]+-linux-amd64.tar.gz")) | .browser_download_url')"
| jq -r '.assets[] | select(.name | match("golangci-lint-[0-9]+.[0-9]+.[0-9]+-linux-amd64.tar.gz$")) | .browser_download_url')"
@aramprice aramprice merged commit a195910 into windows-2019 May 8, 2026
19 checks passed
@aramprice aramprice deleted the ci-fix-docker-args branch May 8, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants