Skip to content

Move Protect-Dir after ssh install#175

Merged
selzoc merged 1 commit into
windows-2019from
move-sshd-order
May 6, 2026
Merged

Move Protect-Dir after ssh install#175
selzoc merged 1 commit into
windows-2019from
move-sshd-order

Conversation

@selzoc
Copy link
Copy Markdown
Member

@selzoc selzoc commented May 6, 2026

No description provided.

ai-assisted=yes
[TNZ-94650]

Co-authored-by: Aram Price <aram.price@broadcom.com>
@selzoc selzoc merged commit 3c1781c into windows-2019 May 6, 2026
14 checks passed
@selzoc selzoc deleted the move-sshd-order branch May 6, 2026 23:30
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 568b027c-b815-4616-ae3d-b474c1b14af2

📥 Commits

Reviewing files that changed from the base of the PR and between 2bdc5d0 and 6f90d9b.

📒 Files selected for processing (2)
  • modules/BOSH.SSH/BOSH.SSH.Tests.ps1
  • modules/BOSH.SSH/BOSH.SSH.psm1

Walkthrough

This pull request introduces a new test case to verify call ordering in the Install-SSHD function, ensuring that Protect-Dir executes after the install-sshd.ps1 script has run. The Install-SSHD function was updated with an exit-code check: the OpenSSH service installer step is now wrapped with Push-Location/Pop-Location and includes a check that throws when the exit code is non-zero. Additionally, comments describing directory permission behavior and authenticated user access to OpenSSH executables and libraries were added or updated. No public entity declarations were modified.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch move-sshd-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants