Fix how local explorer handles multiple workers bound to the same resource#13336
Fix how local explorer handles multiple workers bound to the same resource#13336
Conversation
🦋 Changeset detectedLatest commit: 119b8b7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
f75a7c4 to
42a7527
Compare
|
✅ All changesets look good SummaryReviewed 4 changeset files:
All changesets comply with the formatting guidelines from |
There was a problem hiding this comment.
Minor note: the /api/local/workers handler fetches the dev registry twice per request — once at line 351 to build localWorkers, and again inside getPeerUrlsIfAggregating at line 370 (which internally calls loopback.fetch("http://localhost/core/dev-registry") again). This is a redundant loopback call on every request. Not blocking, but worth noting for a future cleanup.
|
LGTM The changes are clean and well-structured. The PR correctly:
The only minor observation I left was about the duplicate dev-registry fetch in the |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
a73fdc5 to
ff46407
Compare
NuroDev
left a comment
There was a problem hiding this comment.
I'm also seeing locally that the fixture types need to be updated:
❓ Your types might be out of date. Re-run `wrangler types` to ensure your types are correct.
packages/local-explorer-ui/src/routes/workflows/$workflowName/$instanceId.tsx
Show resolved
Hide resolved
08ca563 to
119b8b7
Compare
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
754e51c - update fixture to include resources shared between workers, for testing.
57b6706 - scaffold /local/workers endpoint
bindingsproperty to /local/workers response. This replaces the 'worker' property that was previously added to resource listing endpoints, which incorrectly implies a 1-1 resource to worker mapping, and is also a divergence from the actual list API endpointf270697 - plumb binding config from miniflare to explorer worker
6ae37cc - update sidebar/ui
80ce34a - preserve worker search param on navigation
previously, the selected worker in the sidebar would change when navigating between D1 tables etc.
da577bd - remove workerName from list endpoints
A picture of a cute animal (not mandatory, but encouraged)