Skip to content

fix(vr): move data-vr attrs to ComponentPreview element #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattrothenberg merged 1 commit into from
Mar 27, 2026
Merged

fix(vr): move data-vr attrs to ComponentPreview element #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/kumo-docs-astro/src/components/docs/ComponentExample.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ const vrAttrs = resolvedVrSection
: {};
---

<div class="not-prose overflow-hidden rounded-lg" {...vrAttrs}>
<ComponentPreview>
<div class="not-prose overflow-hidden rounded-lg">
<ComponentPreview {...vrAttrs}>
<slot />
</ComponentPreview>
<div class="component-example-code">
Expand Down
7 changes: 6 additions & 1 deletion packages/kumo-docs-astro/src/components/docs/ComponentPreview.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
---
// Container for component previews/demos
const { class: className, ...rest } = Astro.props;
---

<div
class="flex min-h-[120px] items-center justify-center rounded-t-lg border border-kumo-line bg-kumo-surface p-6"
class:list={[
"flex min-h-[120px] items-center justify-center rounded-t-lg border border-kumo-line bg-kumo-surface p-6",
className,
]}
{...rest}
>
<slot />
</div>
Loading