Skip to content

fix(banners): text token updates on banners#317

Merged
mattrothenberg merged 4 commits intocloudflare:mainfrom
najlaskr:banner-updates
Mar 27, 2026
Merged

fix(banners): text token updates on banners#317
mattrothenberg merged 4 commits intocloudflare:mainfrom
najlaskr:banner-updates

Conversation

@najlaskr
Copy link
Copy Markdown
Contributor

updated token values for info and danger to improve a11y contrast ratio on banners in light mode. both text now passes AA contrast checker requirements.

before
Screenshot 2026-03-26 at 2 14 13 PM

after
Screenshot 2026-03-26 at 2 08 16 PM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 26, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@317

commit: e83009d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

Docs Preview

View docs preview

Commit: e83009d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Visual Regression Report

16 screenshot(s) with visual changes:

Button / Variant: Secondary

355 px (0.31%) changed

Before After Diff
Before After Diff

Button / Variant: Outline

83 px (0.07%) changed

Before After Diff
Before After Diff

Button / Variant: Secondary Destructive

1,258 px (1.09%) changed

Before After Diff
Before After Diff

Button / With Icon

422 px (0.37%) changed

Before After Diff
Before After Diff

Button / Icon Only

32 px (0.03%) changed

Before After Diff
Before After Diff

Button / Loading State

2 px (0%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

138 px (0.12%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

130 px (0.11%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Basic

468 px (0.41%) changed

Before After Diff
Before After Diff

Select / Select Without Label

170 px (0.15%) changed

Before After Diff
Before After Diff

Select / Select With Field

260 px (0.19%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

510 px (0.44%) changed

Before After Diff
Before After Diff

Select / Select Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Multiple

860 px (0.75%) changed

Before After Diff
Before After Diff

Select (Open)

242 px (0%) changed

Before After Diff
Before After Diff
14 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Sizes
  • Button / Disabled State
  • Dialog / Dialog Basic
  • Dialog / Dialog Alert
  • Dialog / Dialog Confirmation
  • Dialog / Dialog With Select
  • Dialog / Dialog With Combobox
  • Select / Select With Tooltip
  • Select / Select Custom Rendering
  • Select / Select Complex

Generated by Kumo Visual Regression

@mattrothenberg mattrothenberg merged commit 7ac73d2 into cloudflare:main Mar 27, 2026
10 checks passed
@najlaskr najlaskr deleted the banner-updates branch March 27, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants