feat(tokens): updated greyscale tokens#306
Closed
najlaskr wants to merge 8 commits intocloudflare:mainfrom
Closed
Conversation
…o surface-tokens
commit: |
Contributor
Docs PreviewCommit: |
Contributor
Visual Regression Report16 screenshot(s) with visual changes: Button / Variants30,752 px (0.69%) changed
Button / Sizes1 px (0%) changed
Button / With Icon6 px (0%) changed
Button / Icon Only10 px (0%) changed
Button / Loading State5 px (0%) changed
Button / Disabled State57,729 px (1.3%) changed
Dialog / Basic Dialog195,744 px (2.17%) changed
Dialog / Alert Dialog (role=“alertdialog”)0 px (0%) changed
Dialog / Confirmation Dialog (withdisablePointerDismissal)
Dialog / With Actions0 px (0%) changed
Dialog / With Select195,744 px (2.17%) changed
Dialog / With Combobox0 px (0%) changed
Dialog / With Dropdown201,064 px (2.23%) changed
Dialog (Open)19,699,570 px (97.74%) changed
Select / Basic0 px (0%) changed
Select (Open)0 px (0%) changed
Generated by Kumo Visual Regression |
Contributor
Author
|
closing this one with updated #326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the semantic token migration by moving surface/background usage to the new base-scale model and applying those tokens across docs + components.
It includes:
Why
The old semantic names (surface/recessed/tint/elevated/interact) were less explicit about relative elevation. This PR standardizes usage around the base-scale model (
canvas,base-neg-*,base,base-*,overlay) so component backgrounds are easier to reason about and more consistent across themes.This migration keeps
kumo-baseas the canonical default surface, sincebaseremains the most commonly used surface token instratustoday. Legacy surface aliases are also preserved to avoid breaking existingstratusstyles while we incrementally migrate usage to the new base-scale token model.