feat(table): add Table.SortIcon and TanStack Table sortable/resizable demo#273
Open
invisal wants to merge 4 commits intocloudflare:mainfrom
Open
feat(table): add Table.SortIcon and TanStack Table sortable/resizable demo#273invisal wants to merge 4 commits intocloudflare:mainfrom
invisal wants to merge 4 commits intocloudflare:mainfrom
Conversation
… demo Add Table.SortIcon sub-component with direction prop (asc/desc/none), fix Table.ResizeHandle to prevent click propagation after drag, and add TanStack Table integration demo with sortable columns and column resizing.
…to match TanStack Table
Replace outdated manual sort icon pattern (ArrowUp/ArrowDown/ArrowsDownUp) with Table.SortIcon, add canSort guard, filler col/row pattern, proper indentation, and escape template literals in the code snippet.
commit: |
Contributor
Docs PreviewCommit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Table.SortIconsub-component for use insideTable.Headto indicate sort direction.directionprop acceptsfalse | "asc" | "desc"— matching TanStack Table'scolumn.getIsSorted()return type exactly, so consumers can pass the value directly without any conversion.Table.ResizeHandleto prevent click events from propagating to the column's sort handler after a drag.Usage