Skip to content

Add chart theme tokens and docs#250

Open
geoquant wants to merge 5 commits intocloudflare:mainfrom
geoquant:geoquant/chart-tokens
Open

Add chart theme tokens and docs#250
geoquant wants to merge 5 commits intocloudflare:mainfrom
geoquant:geoquant/chart-tokens

Conversation

@geoquant
Copy link
Copy Markdown
Collaborator

@geoquant geoquant commented Mar 18, 2026

Summary

  • add kumo-chart-* theme tokens for chart palettes and chart UI colors
  • update chart components to consume theme-config-backed colors instead of hardcoded literals
  • document the new chart tokens on /colors
  • fix docs token sourcing in dev so the Colors token reference reflects the source config
  • fix the Tabs demo anchor accessibility lint issue

Testing

  • pnpm --filter @cloudflare/kumo codegen:themes
  • pnpm --filter @cloudflare/kumo typecheck
  • pnpm --filter @cloudflare/kumo lint
  • pnpm --filter @cloudflare/kumo-docs-astro lint (branch-specific oxlint errors fixed; remaining astro color-template failures are pre-existing elsewhere in the docs package)
  • verified http://localhost:4321/colors renders the new chart token docs and CSS vars locally

Notes

  • includes a changeset for @cloudflare/kumo
Screenshot 2026-03-17 at 10 06 46 PM

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 18, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@250

commit: df8cc03

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2026

Docs Preview

View docs preview

Commit: df8cc03

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 18, 2026

Visual Regression Report

4 screenshot(s) with visual changes:

Button / Loading State

6 px (0%) changed

Before After Diff
Before After Diff

Dialog / Basic Dialog

128,213 px (2.45%) changed

Before After Diff
Before After Diff

Select / Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
23 screenshot(s) unchanged
  • Button / Variants
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Dialog / Alert Dialog (role="alertdialog")
  • Dialog / Confirmation Dialog (with disablePointerDismissal)
  • Dialog / With Actions
  • Dialog / With Select
  • Dialog / With Combobox
  • Dialog / With Dropdown
  • Dialog (Open)
  • Select / Basic Usage
  • Select / Without Visible Label
  • Select / With Description and Error
  • Select / Placeholder
  • Select / Label with Tooltip
  • Select / Custom Rendering
  • Select / Multiple Item
  • Select / Multiple with Custom Indicator
  • Select / More Example
  • Select / Select
  • Select / Select.Option

Generated by Kumo Visual Regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant