Skip to content

[kumo] Add background tint to secondary button hover state #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tccloudflare wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

[kumo] Add background tint to secondary button hover state #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9217d6b
[kumo] Add background tint to secondary button hover state
tccloudflare Mar 5, 2026
6693e3b
[kumo] Add focus state to secondary button variant
tccloudflare Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/secondary-button-hover-tint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudflare/kumo": patch
---

Add subtle background tint on secondary button hover state for better visual feedback
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should be updated to include focus state since the implementation now includes not-disabled:focus:bg-kumo-tint:

Suggested change
Add subtle background tint on secondary button hover state for better visual feedback
Add subtle background tint on secondary button hover and focus states for better visual feedback

2 changes: 1 addition & 1 deletion packages/kumo/src/components/button/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const KUMO_BUTTON_VARIANTS = {
},
secondary: {
classes:
"bg-kumo-control !text-kumo-default ring not-disabled:hover:border-secondary! not-disabled:hover:bg-kumo-control disabled:bg-kumo-control/50 disabled:!text-kumo-default/70 ring-kumo-line data-[state=open]:bg-kumo-control",
"bg-kumo-control !text-kumo-default ring not-disabled:hover:border-secondary! not-disabled:hover:bg-kumo-tint not-disabled:focus:bg-kumo-tint disabled:bg-kumo-control/50 disabled:!text-kumo-default/70 ring-kumo-line data-[state=open]:bg-kumo-control",
description: "Default button style for most actions",
},
ghost: {
Expand Down