Skip to content

fix: improve check polling reliability #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claylo merged 1 commit into from
Jan 17, 2026
Merged

fix: improve check polling reliability #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions git-pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,19 +164,36 @@ if [[ "$SKIP_MERGE" == "true" ]]; then
else
echo "⏳ Waiting for PR checks to complete..."

# Give CI a moment to register checks
sleep 3

# Poll for check status
ELAPSED=0
CHECKS_SEEN=false

while [ "$ELAPSED" -lt "$MAX_WAIT" ]; do
# Get check status as JSON
CHECK_STATUS=$(gh pr view --json statusCheckRollup --jq '.statusCheckRollup[]' 2>/dev/null || echo "")

if [[ -z "$CHECK_STATUS" ]]; then
# No checks configured, safe to merge immediately
echo "✓ No checks configured, proceeding with merge"
break
if [[ "$CHECKS_SEEN" == "true" ]]; then
# Checks disappeared (shouldn't happen), treat as done
echo "✓ No checks remaining, proceeding with merge"
break
elif [[ "$ELAPSED" -ge 10 ]]; then
# Waited 10s and still no checks - likely none configured
echo "✓ No checks configured, proceeding with merge"
break
fi
# Still waiting for checks to register
echo " ⋯ Waiting for checks to register ($ELAPSED/${MAX_WAIT}s)"
sleep "$POLL_INTERVAL"
ELAPSED=$((ELAPSED + POLL_INTERVAL))
continue
fi

CHECKS_SEEN=true

# Count check states
PENDING=$(gh pr view --json statusCheckRollup --jq '[.statusCheckRollup[] | select(.status == "PENDING" or .status == "IN_PROGRESS")] | length' 2>/dev/null || echo "0")
FAILED=$(gh pr view --json statusCheckRollup --jq '[.statusCheckRollup[] | select(.conclusion == "FAILURE")] | length' 2>/dev/null || echo "0")
Expand All @@ -192,8 +209,8 @@ else
exit 1
fi

if [[ "$PENDING" -eq 0 ]] && [[ "$SUCCESS" -eq "$TOTAL" ]] && [[ "$TOTAL" -gt 0 ]]; then
echo "✓ All checks passed ($SUCCESS/$TOTAL)"
if [[ "$PENDING" -eq 0 ]] && [[ "$FAILED" -eq 0 ]] && [[ "$TOTAL" -gt 0 ]]; then
echo "✓ All checks passed ($SUCCESS passed, $((TOTAL - SUCCESS)) skipped)"
break
fi

Expand Down