Skip to content

Fix crash when the last subview is removed #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snowy1803 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

Fix crash when the last subview is removed #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eb747c
Fix crash when the last subview is removed
Snowy1803 Jan 16, 2026
69c2a0a
Add support for watchOS
Snowy1803 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import PackageDescription

let package = Package(
name: "Eventually",
platforms: [.iOS(.v16)],
platforms: [.iOS(.v16), .watchOS(.v9)],
products: [
// Products define the executables and libraries a package produces, making them visible to other packages.
.library(
Expand Down
6 changes: 6 additions & 0 deletions Sources/Eventually/EventuallyLayout.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,12 @@ public struct EventuallyLayout: Layout {
}

if shouldProcessHStack {
// Only process if there are frames to process in the current HStack
guard hStackStartIndex < eventFrames.count else {
hStackStartIndex = index
continue
}

// This rect takes full layout width, vertical position and height is a union of events positions and heights in a stack.
// It is used to get intersections with previous events and form a set of frames where events can be placed.
let combinedHStackRect = (hStackStartIndex ..< eventFrames.count).reduce(
Expand Down