fix: (legacy version) fix utils used for calculating scroll offsets inside of iframes#2017
Open
istateside wants to merge 2 commits intoclauderic:masterfrom
Open
fix: (legacy version) fix utils used for calculating scroll offsets inside of iframes#2017istateside wants to merge 2 commits intoclauderic:masterfrom
istateside wants to merge 2 commits intoclauderic:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 94128e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
istateside
commented
Apr 27, 2026
| } | ||
|
|
||
| return target.ownerDocument?.defaultView ?? window; | ||
| let ownerDoc = target.ownerDocument; |
Author
There was a problem hiding this comment.
This handles when target is the Document object itself
istateside
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for the legacy version of the library - i'm not sure if you're still accepting patches for the @dnd-kit/core and @dnd-kit/utilities libraries, but these were blocking bugs for me
I noticed that scroll offsets are not calculated correctly when the draggable nodes are in a different frame than the execution context.
getScrollableElementwas returningwindowdirectly instead of fetching the correct window object off of theelementargumentand
getWindowwas not properly handling the case where the giventargetelement was a Document object from inside of an iframe, which can be the case if the iframe document has no scrollable element beyond thehtmlnode