Skip to content

fix string escaping in plain format #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckruse merged 1 commit into from
Nov 14, 2025
Merged

fix string escaping in plain format #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/cfpropertylist/rbCFTypes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def to_binary(bplist)
end

def to_plain(plist)
if @value =~ /^\w+$/
if @value =~ /\A\w+\z/
@value
else
quoted
Expand All @@ -74,15 +74,15 @@ def quoted
when '"'
'\\"'
when '\\'
'\\'
'\\\\'
when "\a"
"\\a"
when "\b"
"\\b"
when "\f"
"\\f"
when "\n"
"\n"
"\\n"
when "\v"
"\\v"
when "\r"
Expand Down
24 changes: 24 additions & 0 deletions test/test_plain.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,28 @@ def test_serialize
plist.value = CFPropertyList.guess(CFPropertyList::Blob.new("\x00\n"))
assert_equal raw_plain("binary"), plist.to_str(CFPropertyList::List::FORMAT_PLAIN)
end

def test_string_with_backslash_roundtrip
original = "foo\\bar"
plist = CFPropertyList::List.new
plist.value = CFPropertyList.guess(original)
plain = plist.to_str(CFPropertyList::List::FORMAT_PLAIN)

reparsed = CFPropertyList::List.new(:data => plain, :format => CFPropertyList::List::FORMAT_PLAIN)
result = CFPropertyList.native_types(reparsed.value)

assert_equal original, result
end

def test_string_with_newline_roundtrip
original = "foo\nbar"
plist = CFPropertyList::List.new
plist.value = CFPropertyList.guess(original)
plain = plist.to_str(CFPropertyList::List::FORMAT_PLAIN)

reparsed = CFPropertyList::List.new(:data => plain, :format => CFPropertyList::List::FORMAT_PLAIN)
result = CFPropertyList.native_types(reparsed.value)

assert_equal original, result
end
end