UTF8 utility functions#4
Open
RobertFischer wants to merge 3 commits into
Open
Conversation
Author
|
Adding in Closes #2 (for good measure). |
Contributor
|
@RobertFischer , if you remove the |
Author
|
Will do.
~~ RCF.
Joe Vargas:
… @RobertFischer , if you remove the `.stylish-haskell.yaml` file and undo the extra padding on the qualified lines, I think it's worth merging. I don't have merging privileges though.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the pull request discussed in Issue #2, and it's the same as PR #3, except that the branch name is meaningful.
Basic utility functions to convert from and to UTF8 without having to do wrapping and unwrapping yourself. Tests are included.
The only potential controversial bit is that I also dropped in a
.stylish-haskell.yamlwhich is pretty much in line with the coding style that was already there. It won't do any harm if people do not usestylish-haskell, and it's very useful for those who do.