feat(columnar): implement dynamic chunk group allocations#8202
Open
imranzaheer612 wants to merge 5 commits intocitusdata:mainfrom
Open
feat(columnar): implement dynamic chunk group allocations#8202imranzaheer612 wants to merge 5 commits intocitusdata:mainfrom
imranzaheer612 wants to merge 5 commits intocitusdata:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Add support for dynamically allocating new chunk groups when the configurable size limit is reached. This prevents memory allocation failures and improves scalability for large columnar data sets. - Add new GUC parameter `columnar.chunk_group_size_limit` to control chunk group size threshold - Add regression tests covering chunk group expansion scenarios - Add `chunk_group_size_limit` column to columnar_internal.options updated in citus_columnar--13.2-1--14.0-1.sql Fixes citusdata#6420
- In citus_columnar--14.0-1--13.2-1 remove the new column that was introduced in 14.0.1
- When compression is enable, in case for a worst compression input_data_size < compressed_data_size. This will increease the data length and again will cause enlargeStringInfo() failures. - We should also account for this change before allocation/deciding a new chunk group. GetMaxCompressedLength() will help us calculating the expected worst compressed sizes before hand.
ba64c9f to
292247e
Compare
There were still some issues in adjujsting chunk index and chunk row index after every compute. This was causing failures for some edge cases i.e. reaching chunk row limit. A better way would be keep track of these indices intead of recomputing and adjujsting them on every row iteration.
a1aa22b to
9f52f6a
Compare
Contributor
Author
|
Looks like this is an other related issue: #7199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for dynamically allocating new chunk groups when the configurable size limit is reached. This prevents memory allocation failures and improves scalability for large columnar data sets.
columnar.chunk_group_size_limitto control chunk group size thresholdchunk_group_size_limitcolumn to columnar_internal.options updated in citus_columnar--12.2-1--13.2-1.sqlFixes #6420, #7199
BEFORE:
AFTER