Use Express4 route instead of app. Fixes ejs view#29
Open
zevero wants to merge 3 commits into
Open
Conversation
Author
|
Please merge ... there is no drawback :) |
ujade
approved these changes
Dec 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrating you gallery into my express app, res.render had problems finding my view directory.
After changing from app to router I am fine.
For standalone "views" and "view engine" are already set in examples/app.js so no need to set twice. I suspect you needed to set it again since a new app can not be aware of it. But router is.