Update to address recurring R-CMD-Check failures#44
Open
chriscarrollsmith wants to merge 10 commits into
Open
Conversation
Merge branch 'main' of https://github.com/chriscarrollsmith/imfr # Conflicts: # .Rbuildignore
Collaborator
Author
|
Hah! I wrote that, and then I went and ran simultaneous checks on the R and Python libraries, causing both to fail. Will slow the test process a bit more tomorrow morning and try again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recurring failures of R-CMD-Check were due to hitting a universal bandwidth limit on the API. I've implemented a local-disk caching system and a new throttling option to enforce a wait time between function calls. If the problem persists, fixing it should be a simple matter of setting the option to a higher wait time during tests. But I've done several runs, and so far it looks good.
Use of a cache saves on bandwidth, but it didn't particularly improve runtime—at least not with my high-speed Internet. Caching is turned on by default, but I've made it togglable with an option, so the default can always be changed in a future patch if it turns out to be more trouble than it's worth.