Skip to content

Annotations are not deselected when heading changes #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muccy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Annotations are not deselected when heading changes #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
699b272
Annotations are not deselected when heading changes
muccy Dec 11, 2014
00d6d5c
Use new logic only when map is tracking with heading
muccy Dec 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions CCHMapClusterController/CCHMapClusterController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ @interface CCHMapClusterController()<MKMapViewDelegate>
@property (nonatomic) id<MKAnnotation> annotationToSelect;
@property (nonatomic) CCHMapClusterAnnotation *mapClusterAnnotationToSelect;
@property (nonatomic) MKCoordinateSpan regionSpanBeforeChange;
@property (nonatomic) CLLocationDistance mapCameraAltitudeBeforeRegionChange;
@property (nonatomic, getter = isRegionChanging) BOOL regionChanging;
@property (nonatomic) id<CCHMapClusterer> strongClusterer;
@property (nonatomic) id<CCHMapAnimator> strongAnimator;
Expand Down Expand Up @@ -279,16 +280,31 @@ - (void)mapView:(MKMapView *)mapView didAddAnnotationViews:(NSArray *)annotation
- (void)mapView:(MKMapView *)mapView regionWillChangeAnimated:(BOOL)animated
{
self.regionSpanBeforeChange = mapView.region.span;

if ([mapView respondsToSelector:@selector(camera)]) {
self.mapCameraAltitudeBeforeRegionChange = mapView.camera.altitude;
}

self.regionChanging = YES;
}

- (void)mapView:(MKMapView *)mapView regionDidChangeAnimated:(BOOL)animated
{
self.regionChanging = NO;

// Deselect all annotations when zooming in/out. Longitude delta will not change
// unless zoom changes (in contrast to latitude delta).
BOOL hasZoomed = !fequal(mapView.region.span.longitudeDelta, self.regionSpanBeforeChange.longitudeDelta);
// Deselect all annotations when zooming in/out.
BOOL hasZoomed;
if (mapView.userTrackingMode == MKUserTrackingModeFollowWithHeading && [mapView respondsToSelector:@selector(camera)])
{
hasZoomed = !fequal(mapView.camera.altitude, self.mapCameraAltitudeBeforeRegionChange);
}
else {
// Longitude delta will not change unless zoom changes (in contrast to
// latitude delta). Unfortunately this is not true while heading is
// changed
hasZoomed = !fequal(mapView.region.span.longitudeDelta, self.regionSpanBeforeChange.longitudeDelta);
}

if (hasZoomed) {
[self deselectAllAnnotations];
}
Expand Down