Skip to content

fix: swallow client-disconnect errors in JSON response writer #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chodeus merged 1 commit into from
Apr 17, 2026
+15 −9
Merged

fix: swallow client-disconnect errors in JSON response writer #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions app/webui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,15 +471,21 @@ def log_message(self, format, *args):

def _json_response(self, data, status=200, cookies=None):
body = json.dumps(data).encode('utf-8')
self.send_response(status)
self.send_header('Content-Type', 'application/json')
self.send_header('Content-Length', len(body))
self.send_header('Cache-Control', 'no-cache')
if cookies:
for cookie in cookies:
self.send_header('Set-Cookie', cookie)
self.end_headers()
self.wfile.write(body)
try:
self.send_response(status)
self.send_header('Content-Type', 'application/json')
self.send_header('Content-Length', len(body))
self.send_header('Cache-Control', 'no-cache')
if cookies:
for cookie in cookies:
self.send_header('Set-Cookie', cookie)
self.end_headers()
self.wfile.write(body)
except (ConnectionResetError, BrokenPipeError):
# Client disconnected before we could reply (common for
# long-running endpoints like /api/delete). Server-side
# work already completed; nothing to do.
pass

def _read_body(self):
"""Parse JSON request body. Returns dict or None on error."""
Expand Down
Loading