Rebased multiple attachments#85
Conversation
|
This works with multiple image files, or image + audio files (see #84). Strangely initial tests with text/json files did not seem to work. |
|
This is really cool feature. Will it be merged to the master? |
|
And, it's not working on Android with multiple attachments. But i have fixed it, i can send you the RNMailModule.java if you want. |
|
@tomislavHonig please send a PR to my fork, I will merge there and then it will appear here. |
|
Thing is i am using FileProvider https://developer.android.com/reference/android/support/v4/content/FileProvider.html and you need to set this up in the androidManifest and create xml folder with provider_paths.xml file inside it. Don't know if you can do that inside the module, i think it needs to be done on application level. |
|
Any updates on this? Need this feature either. |
|
@adamski can you rebase. seems like the formatting/indentation is off. |
|
@chirag04 formatting seems fine? I thought I'd fixed the indentation issue. Please link to the specific line numbers you're seeing. Also would be good to include @tomislavHonig's Android fixes too. |
|
Closing, replaced with #92 |
Rebased #11 (the first PR for multiple attachments). Tested and working on iOS.
Breaking changes
attachment:{}is nowattachments:[], e.g.: