Skip to content

Workaround for Android Multiple Attachments bug#158

Merged
chirag04 merged 1 commit into
chirag04:masterfrom
Relax594:patch-1
Aug 25, 2020
Merged

Workaround for Android Multiple Attachments bug#158
chirag04 merged 1 commit into
chirag04:masterfrom
Relax594:patch-1

Conversation

@Relax594
Copy link
Copy Markdown
Contributor

this workaround allows to send one attachment in the current v5. This allows users to update to v5 if they only need to send one attachment.

this workaround allows to send one attachment in the current v5.
@chirag04 chirag04 merged commit 5a28255 into chirag04:master Aug 25, 2020
@chirag04
Copy link
Copy Markdown
Owner

Thank you sending the patch 🙌

@Relax594 Relax594 deleted the patch-1 branch August 25, 2020 12:34
@geraintwhite
Copy link
Copy Markdown
Contributor

This change introduces a issue where the user sees the message "Permission denied for the attachment" and the file is not attached. (I only tested on the Samsung mail and Gmail apps on Android 10)

@Relax594
Copy link
Copy Markdown
Contributor Author

Relax594 commented Sep 1, 2020

That's definitely an issue on your side. You have to ask for the permission by yourself within your app. This commit doesn't change anything in the way percussions are used or needed.

@geraintwhite
Copy link
Copy Markdown
Contributor

Hmm, I think it's a problem in newer versions of Android related to #127.

I fixed the multiple attachments in my PR #161 and I think the permissions issue was solved by using grantUriPermission.

@Relax594
Copy link
Copy Markdown
Contributor Author

Relax594 commented Sep 2, 2020

I don't have any issues using android 9 and 10. Weird one. I will have a look into your PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants